GitHub user gaborgsomogyi opened a pull request:

    [SPARK-26304][SS] Add default value to parameter

    ## What changes were proposed in this pull request? is an optional parameter but most of 
the time value `kafka` ha to be set. As I've written in the jira the following 
reasoning is behind:
    * Kafka's configuration guide suggest the same value:
    * It would be easier for spark users by providing less configuration
    * Other streaming engines are doing the same
    In this PR I've changed the parameter from optional to `WithDefault` and 
set `kafka` as default value.
    ## How was this patch tested?
    Available unit tests + on cluster.

You can merge this pull request into a Git repository by running:

    $ git pull SPARK-26304

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #23254
commit 3f56e78e45e9c983816d8222e06d33092ecb2993
Author: Gabor Somogyi <gabor.g.somogyi@...>
Date:   2018-12-06T15:37:35Z

    [SPARK-26304][SS] Add default value to parameter



To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to