GitHub user gaborgsomogyi opened a pull request:

    https://github.com/apache/spark/pull/23254

    [SPARK-26304][SS] Add default value to 
spark.kafka.sasl.kerberos.service.name parameter

    ## What changes were proposed in this pull request?
    
    spark.kafka.sasl.kerberos.service.name is an optional parameter but most of 
the time value `kafka` ha to be set. As I've written in the jira the following 
reasoning is behind:
    * Kafka's configuration guide suggest the same value: 
https://kafka.apache.org/documentation/#security_sasl_kerberos_brokerconfig
    * It would be easier for spark users by providing less configuration
    * Other streaming engines are doing the same
    
    In this PR I've changed the parameter from optional to `WithDefault` and 
set `kafka` as default value.
    
    ## How was this patch tested?
    
    Available unit tests + on cluster.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gaborgsomogyi/spark SPARK-26304

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/23254.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #23254
    
----
commit 3f56e78e45e9c983816d8222e06d33092ecb2993
Author: Gabor Somogyi <gabor.g.somogyi@...>
Date:   2018-12-06T15:37:35Z

    [SPARK-26304][SS] Add default value to 
spark.kafka.sasl.kerberos.service.name parameter

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to