Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/23207#discussion_r239990986
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala ---
@@ -38,13 +38,21 @@ case class CollectLimitExec(limit: Int, child:
SparkPlan) extends UnaryExecNode
override def outputPartitioning: Partitioning = SinglePartition
override def executeCollect(): Array[InternalRow] =
child.executeTake(limit)
private val serializer: Serializer = new
UnsafeRowSerializer(child.output.size)
- override lazy val metrics =
SQLShuffleMetricsReporter.createShuffleReadMetrics(sparkContext)
+ private lazy val writeMetrics =
+ SQLShuffleWriteMetricsReporter.createShuffleWriteMetrics(sparkContext)
+ private lazy val readMetrics =
+ SQLShuffleMetricsReporter.createShuffleReadMetrics(sparkContext)
--- End diff --
I feel it is better to rename SQLShuffleMetricsReporter to
SQLShuffleReadMetricsReporter to make it match with
SQLShuffleWriteMetricsReporter. It can be in a followup.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
