Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23225#discussion_r240014126
--- Diff:
core/src/test/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriterSuite.java
---
@@ -235,11 +235,8 @@ public void writeEmptyIterator() throws Exception {
final Option<MapStatus> mapStatus = writer.stop(true);
assertTrue(mapStatus.isDefined());
assertTrue(mergedOutputFile.exists());
+ assertEquals(0, spillFilesCreated.size());
assertArrayEquals(new long[NUM_PARTITITONS],
partitionSizesInMergedFile);
- assertEquals(0, taskMetrics.shuffleWriteMetrics().recordsWritten());
- assertEquals(0, taskMetrics.shuffleWriteMetrics().bytesWritten());
- assertEquals(0, taskMetrics.diskBytesSpilled());
- assertEquals(0, taskMetrics.memoryBytesSpilled());
--- End diff --
We need to keep these test coverage guaranteeing that the task metrics
remained an untouched state.
Please revert this removal.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
