Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23253#discussion_r240048780
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/BadRecordException.scala
 ---
    @@ -20,6 +20,16 @@ package org.apache.spark.sql.catalyst.util
     import org.apache.spark.sql.catalyst.InternalRow
     import org.apache.spark.unsafe.types.UTF8String
     
    +/**
    + * Exception thrown when the underlying parser returns a partial result of 
parsing.
    + * @param partialResult the partial result of parsing a bad record.
    + * @param cause the actual exception about why the parser cannot return 
full result.
    + */
    +case class PartialResultException(
    --- End diff --
    
    Ur, is this intentional? It looks like 
`javax.naming.PartialResultException` to me. Not only the same name, but also 
the semantics.
    
    @cloud-fan . Is this okay? Or, shall we use more distinguishable name like 
`SparkPartialResultException` instead?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to