Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/3419#issuecomment-64154353
Hey TD. I took a pass on this and it looks great. I think the current
design is as simple as it can be, well commented, and logically sound. One
thing I'm not totally sure on is how this works during recovery, mostly because
I am just not deeply familiar with the way recovery works overall in streaming.
But in terms of the normal case operation this LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
