xuanyuanking opened a new pull request #23277: [SPARK-26327][SQL] Metrics in 
FileSourceScanExec not update correctly
URL: https://github.com/apache/spark/pull/23277
 
 
   ## What changes were proposed in this pull request?
   
   As the description in 
[SPARK-26327](https://issues.apache.org/jira/browse/SPARK-26327), 
`postDriverMetricUpdates` was called on wrong place cause this bug, fix this by 
split the initializing of `selectedPartitions` and metrics updating logic. Add 
the updating logic in `inputRDD` initializing which can take effect in both 
code generation node and normal node.
   ## How was this patch tested?
   
   New test case in `SQLMetricsSuite`.
   Manual test:
   
   |         | Before | After |
   |---------|:--------:|:-------:|
   | CodeGen 
|![image](https://user-images.githubusercontent.com/4833765/49741753-13c7e800-fcd2-11e8-97a8-8057b657aa3c.png)|![image](https://user-images.githubusercontent.com/4833765/49741774-1f1b1380-fcd2-11e8-98d9-78b950f4e43a.png)|
   | Normal  
|![image](https://user-images.githubusercontent.com/4833765/49741836-378b2e00-fcd2-11e8-80c3-ab462a6a3184.png)|![image](https://user-images.githubusercontent.com/4833765/49741860-4a056780-fcd2-11e8-9ef1-863de217f183.png)|
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to