icexelloss commented on a change in pull request #23279: [SPARK-26328][SQL] Use
GenerateOrdering for group key comparision in WindowExec
URL: https://github.com/apache/spark/pull/23279#discussion_r240331510
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExec.scala
##########
@@ -333,13 +331,13 @@ case class WindowExec(
val numFrames = frames.length
private[this] def fetchNextPartition() {
// Collect all the rows in the current partition.
- // Before we start to fetch new input rows, make a copy of nextGroup.
- val currentGroup = nextGroup.copy()
+ // Before we start to fetch new input rows, make a copy of nextRow.
+ val currentRow = nextRow.copy()
// clear last partition
buffer.clear()
- while (nextRowAvailable && nextGroup == currentGroup) {
+ while (nextRowAvailable && groupOrdering.compare(currentRow,
nextRow) == 0) {
Review comment:
Discussed here:
https://github.com/apache/spark/pull/22305/commits/850541873df1101485a85632b85ba474dac67d56#r239312302
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
