viirya commented on issue #23272: [SPARK-26265][Core] Fix deadlock in BytesToBytesMap.MapIterator when locking both BytesToBytesMap.MapIterator and TaskMemoryManager URL: https://github.com/apache/spark/pull/23272#issuecomment-446059510 I think the page is used exclusively by the map and the iterator. So it could not be freed by other consumer. On Tue, Dec 11, 2018, 10:23 Wenchen Fan <[email protected] wrote: > *@cloud-fan* commented on this pull request. > ------------------------------ > > In core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java > <https://github.com/apache/spark/pull/23272#discussion_r240453178>: > > > @@ -283,6 +290,9 @@ private void advanceToNextPage() { > } > } > } > + if (pageToFree != null) { > + freePage(pageToFree); > > is it possible that this page is already freed by another consumer? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/spark/pull/23272#pullrequestreview-183486914>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAEM9-_lp7w_wK9mWUYjtPT1h9o5O0rzks5u3xcSgaJpZM4ZK2_Y> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
