Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3411#discussion_r20815764
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -87,14 +92,14 @@ private[history] class FsHistoryProvider(conf:
SparkConf) extends ApplicationHis
private def initialize() {
// Validate the log directory.
- val path = new Path(resolvedLogDir)
+ val path = new Path(logDir)
if (!fs.exists(path)) {
--- End diff --
Ok, I think the following makes the most sense:
If the dir does not exist, we throw an exception complaining that the
directory doesn't exist. Additionally, if the config is not set, we also point
the user to set it.
If the dir does exist, we proceed as normal whether or not the config is
set. Additionally, if there are no finished applications, then we ask the user
to verify whether the correct log dir is set (see screenshot).
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
