srowen commented on a change in pull request #23288: [SPARK-26339][SQL]Throws 
better exception when reading files that start with underscore
URL: https://github.com/apache/spark/pull/23288#discussion_r240781003
 
 

 ##########
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
 ##########
 @@ -554,7 +554,8 @@ case class DataSource(
 
       // Sufficient to check head of the globPath seq for non-glob scenario
       // Don't need to check once again if files exist in streaming mode
-      if (checkFilesExist && !fs.exists(globPath.head)) {
+      if (checkFilesExist &&
+          (!fs.exists(globPath.head) || 
InMemoryFileIndex.shouldFilterOut(globPath.head.getName))) {
 
 Review comment:
   I'm probably misunderstanding, but doesn't this still cause it to throw a 
'Path does not exist' exception?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to