dongjoon-hyun commented on a change in pull request #23284: [SPARK-26337][SQL][TEST] Add benchmark for LongToUnsafeRowMap URL: https://github.com/apache/spark/pull/23284#discussion_r240799221
########## File path: sql/core/benchmarks/HashedRelationMetricsBenchmark-results.txt ########## @@ -6,6 +6,6 @@ Java HotSpot(TM) 64-Bit Server VM 1.8.0_181-b13 on Mac OS X 10.13.6 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz LongToUnsafeRowMap metrics: Best/Avg Time(ms) Rate(M/s) Per Row(ns) Relative ------------------------------------------------------------------------------------------------ -LongToUnsafeRowMap 1265 / 1336 0.4 2530.5 1.0X +LongToUnsafeRowMap 234 / 315 2.1 467.3 1.0X Review comment: Yep. It's a clear reason to have this benchmark. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
