HeartSaVioR commented on a change in pull request #22952: [SPARK-20568][SS]
Provide option to clean up completed files in streaming query
URL: https://github.com/apache/spark/pull/22952#discussion_r240894261
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSource.scala
##########
@@ -329,4 +345,124 @@ object FileStreamSource {
def size: Int = map.size()
}
+
+ class FileStreamSourceCleaner(fileSystem: FileSystem, sourcePath: Path,
+ baseArchivePathString: Option[String]) extends
Logging {
+
+ private val sourceGlobFilters: Seq[GlobFilter] =
buildSourceGlobFilters(sourcePath)
+
+ private val baseArchivePath: Option[Path] = baseArchivePathString.map(new
Path(_))
+
+ def archive(entry: FileEntry): Unit = {
+ require(baseArchivePath.isDefined)
+
+ val curPath = new Path(new URI(entry.path))
+ val curPathUri = curPath.toUri
+
+ val newPath = buildArchiveFilePath(curPathUri)
+
+ if (baseArchivePath.get.depth() <= 2) {
Review comment:
It's just a shortcut of condition: given that source pattern will read files
which exactly match to the pattern, or their parents match the pattern. Once we
are adding base archive path as prefix of final path, if the depth of base
archive path is greater than 2, FileStreamSource will not read the archived
file as source.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
