kevinyu98 commented on a change in pull request #23108:
[Spark-25993][SQL][TEST]Add test cases for CREATE EXTERNAL TABLE with
subdirectories
URL: https://github.com/apache/spark/pull/23108#discussion_r241157209
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveParquetSourceSuite.scala
##########
@@ -222,4 +222,61 @@ class HiveParquetSourceSuite extends
ParquetPartitioningTest {
assert(df4.columns === Array("str", "max_int"))
}
}
+
+ test("SPARK-25993 CREATE EXTERNAL TABLE with subdirectories") {
Review comment:
@dongjoon-hyun Thanks for the comments, I have tried to make the changes for
the first and second review comments, I changed both suites to make it looks
similar, also add more test cases. For the 3rd comments, I haven't found a
common place to both suites, when you say the help function missing in the
previous commit, can you help to point what kind of help function I missed?
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
