BryanCutler commented on a change in pull request #22305:
[SPARK-24561][SQL][Python] User-defined window aggregation functions with
Pandas UDF (bounded window)
URL: https://github.com/apache/spark/pull/22305#discussion_r241215618
##########
File path: python/pyspark/sql/tests/test_pandas_udf_window.py
##########
@@ -47,6 +47,15 @@ def pandas_scalar_time_two(self):
from pyspark.sql.functions import pandas_udf
return pandas_udf(lambda v: v * 2, 'double')
+ @property
+ def pandas_agg_count_udf(self):
+ from pyspark.sql.functions import pandas_udf, PandasUDFType
Review comment:
this import and all the others should be moved to the top, it's repeated
many times. It could done be a follow though
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
