felixcheung commented on a change in pull request #23293: [MINOR][R] Fix
indents of sparkR welcome message to be consistent with pyspark and spark-shell
URL: https://github.com/apache/spark/pull/23293#discussion_r241298433
##########
File path: R/pkg/inst/profile/shell.R
##########
@@ -33,19 +33,19 @@
sc <- SparkR:::callJStatic("org.apache.spark.sql.api.r.SQLUtils",
"getJavaSparkContext", spark)
assign("sc", sc, envir = .GlobalEnv)
sparkVer <- SparkR:::callJMethod(sc, "version")
- cat("\n Welcome to")
+ cat("\nWelcome to")
cat("\n")
- cat(" ____ __", "\n")
- cat(" / __/__ ___ _____/ /__", "\n")
- cat(" _\\ \\/ _ \\/ _ `/ __/ '_/", "\n")
- cat(" /___/ .__/\\_,_/_/ /_/\\_\\")
+ cat(" ____ __", "\n")
+ cat(" / __/__ ___ _____/ /__", "\n")
+ cat(" _\\ \\/ _ \\/ _ `/ __/ '_/", "\n")
+ cat(" /___/ .__/\\_,_/_/ /_/\\_\\")
if (nchar(sparkVer) == 0) {
cat("\n")
} else {
- cat(" version ", sparkVer, "\n")
+ cat(" version", sparkVer, "\n")
Review comment:
actually, IMO it's better to
```
cat(" version ", sparkVer, "\n", sep = "")
```
because otherwise it's still injecting space
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
