MaxGekk commented on a change in pull request #23196: [SPARK-26243][SQL] Use
java.time API for parsing timestamps and dates from JSON
URL: https://github.com/apache/spark/pull/23196#discussion_r241316473
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatter.scala
##########
@@ -116,29 +127,32 @@ sealed trait DateFormatter {
class Iso8601DateFormatter(
pattern: String,
- timeZone: TimeZone,
- locale: Locale) extends DateFormatter {
+ locale: Locale) extends DateFormatter with FormatterUtils {
- val dateTimeFormatter = new Iso8601DateTimeFormatter(pattern, timeZone,
locale)
+ val zoneId = ZoneId.of("GMT")
Review comment:
Thanks for the link. I probably read the same when I thought what is better
to use. What confused me is **GMT is a time zone** vs **UTC is not a time zone**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
