cloud-fan commented on a change in pull request #23196: [SPARK-26243][SQL] Use
java.time API for parsing timestamps and dates from JSON
URL: https://github.com/apache/spark/pull/23196#discussion_r241357036
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatter.scala
##########
@@ -116,29 +127,32 @@ sealed trait DateFormatter {
class Iso8601DateFormatter(
pattern: String,
- timeZone: TimeZone,
- locale: Locale) extends DateFormatter {
+ locale: Locale) extends DateFormatter with FormatterUtils {
- val dateTimeFormatter = new Iso8601DateTimeFormatter(pattern, timeZone,
locale)
+ val zoneId = ZoneId.of("GMT")
Review comment:
`UTC` is a time standard, and `GMT` is `UTC+0`. So here looks like `UTC` is
more proper.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
