Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/3435#issuecomment-64309996
By default, Scala generates Java methods for members, no matter whether you
use `val` or `def`. That's why you saw `invokespecial` for `shift` and
`factor`. But if a member is marked as `private[this]`, it generates the code
as a private field, and hence you see `getfield` in the bytecode.
I like using `private[this]` instead of having local references for code
simplicity, but no strong preference. The current form looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
