ankuriitg commented on a change in pull request #23306: [SPARK-26357][Core]
Expose executors' procfs metrics to Metrics system
URL: https://github.com/apache/spark/pull/23306#discussion_r241502663
##########
File path:
core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala
##########
@@ -62,7 +62,21 @@ private[spark] class ProcfsMetricsGetter(procfsDir: String
= "/proc/") extends L
SparkEnv.get.conf.get(config.EVENT_LOG_STAGE_EXECUTOR_METRICS)
val shouldLogStageExecutorProcessTreeMetrics =
SparkEnv.get.conf.get(config.EVENT_LOG_PROCESS_TREE_METRICS)
- procDirExists.get && shouldLogStageExecutorProcessTreeMetrics &&
shouldLogStageExecutorMetrics
+ val shouldAddProcessTreeMetricsToMetricsSet =
+ SparkEnv.get.conf.get(config.METRICS_PROCESS_TREE_METRICS)
+ val pickEitherUIOrMetricsSet = shouldLogStageExecutorProcessTreeMetrics ^
+ shouldAddProcessTreeMetricsToMetricsSet
+ val areBothUIMetricsEnabled = shouldLogStageExecutorProcessTreeMetrics &&
+ shouldAddProcessTreeMetricsToMetricsSet
+ if (areBothUIMetricsEnabled) {
+ logWarning("You have enabled " +
+ "both spark.eventLog.logStageExecutorProcessTreeMetrics.enabled" +
+ " and spark.metrics.logStageExecutorProcessTreeMetrics.enabled. This
isn't " +
+ "allowed. As a result Procfs metrics won't be reported to UI or
Metricsset")
+ }
+ (procDirExists.get && shouldLogStageExecutorMetrics &&
pickEitherUIOrMetricsSet) ||
Review comment:
Can the return statement be simplified to:
`procDirExists.get && pickEitherUIOrMetricsSet && !areBothUIMetricsEnabled`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
