weixiuli commented on a change in pull request #23243: [SPARK-26288][CORE]add
initRegisteredExecutorsDB
URL: https://github.com/apache/spark/pull/23243#discussion_r241940942
##########
File path: core/src/test/scala/org/apache/spark/deploy/worker/WorkerSuite.scala
##########
@@ -243,4 +243,13 @@ class WorkerSuite extends SparkFunSuite with Matchers
with BeforeAndAfter {
ExecutorStateChanged("app1", 0, ExecutorState.EXITED, None, None))
assert(cleanupCalled.get() == value)
}
+ test("test initRegisteredExecutorsDB ") {
+ val sparkConf = new SparkConf()
+ Utils.loadDefaultSparkProperties(sparkConf)
+ val securityManager = new SecurityManager(sparkConf)
+ sparkConf.set(config.SHUFFLE_SERVICE_DB_ENABLED.key, "true")
+ sparkConf.set(config.SHUFFLE_SERVICE_ENABLED.key, "true")
+ sparkConf.set("spark.local.dir", "/tmp")
+ val externalShuffleService = new ExternalShuffleService(sparkConf,
securityManager)
Review comment:
@dongjoon-hyun Thanks a lot,I have fixed scalastyle and removed the test
ablove yet.
There is a new test to test this patch.
Kindly review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
