dongjoon-hyun commented on a change in pull request #23325: [SPARK-26376][SQL]
Skip inputs without tokens by JSON datasource
URL: https://github.com/apache/spark/pull/23325#discussion_r241963998
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
##########
@@ -66,7 +66,11 @@ class JsonSuite extends QueryTest with SharedSQLContext
with TestJsonData {
val dummyOption = new JSONOptions(Map.empty[String, String], "GMT")
val dummySchema = StructType(Seq.empty)
- val parser = new JacksonParser(dummySchema, dummyOption,
allowArrayAsStructs = true)
+ val parser = new JacksonParser(
+ dummySchema,
+ dummyOption,
+ allowArrayAsStructs = true,
+ skipInputWithoutTokens = true)
Review comment:
Shall we have a test coverage for both `true` and `false`? In case of
`false`, we should not skip the rows, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
