HyukjinKwon commented on a change in pull request #23202: [SPARK-26248][SQL] 
Infer date type from CSV
URL: https://github.com/apache/spark/pull/23202#discussion_r242010787
 
 

 ##########
 File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVInferSchema.scala
 ##########
 @@ -104,6 +108,7 @@ class CSVInferSchema(val options: CSVOptions) extends 
Serializable {
           compatibleType(typeSoFar, 
tryParseDecimal(field)).getOrElse(StringType)
         case DoubleType => tryParseDouble(field)
         case TimestampType => tryParseTimestamp(field)
+        case DateType => tryParseDate(field)
 
 Review comment:
   Another problem here is the order here matters when type is being merged. 
For instance, date type is inferred first, and then if timestamp is found, it 
won't detect timestamp type anymore.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to