HyukjinKwon commented on a change in pull request #23263: [SPARK-23674][ML] 
Adds Spark ML Events to Pipeline
URL: https://github.com/apache/spark/pull/23263#discussion_r242074573
 
 

 ##########
 File path: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala
 ##########
 @@ -197,20 +197,22 @@ object Pipeline extends MLReadable[Pipeline] {
   @Since("1.6.0")
   override def load(path: String): Pipeline = super.load(path)
 
-  private[Pipeline] class PipelineWriter(instance: Pipeline) extends MLWriter {
+  private[Pipeline] class PipelineWriter(val instance: Pipeline) extends 
MLWriter {
 
 Review comment:
   It just became `val` to make a variable internally so that the tests check 
the instance. It's still not visible to end users in any way. No diff.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to