HeartSaVioR commented on a change in pull request #23285: [SPARK-26224][SQL]
Warn and advice the user when creating many project on subsequent calls to
withColumn
URL: https://github.com/apache/spark/pull/23285#discussion_r242335444
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
##########
@@ -2154,6 +2155,18 @@ class Dataset[T] private[sql](
colNames,
"in given column names",
sparkSession.sessionState.conf.caseSensitiveAnalysis)
+ var numProjects = 0
+ var currPlan = logicalPlan
+ while (currPlan.isInstanceOf[Project] && numProjects < 50) {
Review comment:
How about checking the count of continuous projection and keep/reduce the
count? I can't imagine end users to create more than (like) 20 times projection
without withColumn/drop/etc instead of select.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
