ankuriitg commented on a change in pull request #23306: [SPARK-26357][Core]
Expose executors' procfs metrics to Metrics system
URL: https://github.com/apache/spark/pull/23306#discussion_r242358552
##########
File path:
core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala
##########
@@ -37,7 +37,9 @@ private[spark] case class ProcfsMetrics(
pythonVmemTotal: Long,
pythonRSSTotal: Long,
otherVmemTotal: Long,
- otherRSSTotal: Long)
+ otherRSSTotal: Long,
+ timeStamp: Long)
Review comment:
I think the point that both I and Imran are trying to make here is that
timestamp is not a metric and thus it should not be kept inside ProcfsMetrics.
The purpose of timestamp is to evict older cached metrics and thus it should be
a part of ProcfsMetricsGetter along with `cachedAllMetric`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
