vanzin commented on a change in pull request #23337: [SPARK-26019][PYSPARK]
Allow insecure py4j gateways
URL: https://github.com/apache/spark/pull/23337#discussion_r242368453
##########
File path: python/pyspark/context.py
##########
@@ -112,6 +112,18 @@ def __init__(self, master=None, appName=None,
sparkHome=None, pyFiles=None,
ValueError:...
"""
self._callsite = first_spark_call() or CallSite(None, None, None)
+ if gateway is not None and gateway.gateway_parameters.auth_token is
None:
+ if conf and conf.get("spark.python.allowInsecurePy4j", "false") ==
"true":
Review comment:
This requires the config to be set in the `SparkConf` object, instead of
allowing it to be in a config file, right? I don't think the config file has
been read at this point in the code.
The issue I see with that is that it would require code changes to make this
work, instead of being simply something to add to a config file in apps that
currently pass in insecure gateways.
(But then, given that the config file is probably read by the JVM, you'd
have a chicken-and-egg problem, so maybe this is ok...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
