Github user brkyvz commented on the pull request:
https://github.com/apache/spark/pull/3319#issuecomment-64505065
@mengxr:
Thanks for the feedback. Added the Java tests!
horzcat and vertcat are in fact MATLAB methods:
http://www.mathworks.com/help/matlab/ref/horzcat.html
http://www.mathworks.com/help/matlab/ref/vertcat.html
They are the underlying methods that are called when someone writes
`A = [A1 A2; A3 A4];`
I felt the naming was more intuitive as it is like `strcat`, because you
are concatenating matrices either
horizontally or vertically. I'd be happy to change them to `hstack` and
`vstack`, but horzcat sounds more intuitive to me (maybe I'm biased, because I
used to use it more).
Your call :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
