mgaido91 commented on a change in pull request #23285: [SPARK-26224][SQL] Warn
and advice the user when creating many project on subsequent calls to withColumn
URL: https://github.com/apache/spark/pull/23285#discussion_r242448253
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
##########
@@ -2154,6 +2155,18 @@ class Dataset[T] private[sql](
colNames,
"in given column names",
sparkSession.sessionState.conf.caseSensitiveAnalysis)
+ var numProjects = 0
+ var currPlan = logicalPlan
+ while (currPlan.isInstanceOf[Project] && numProjects < 50) {
Review comment:
What do you mean @HeartSaVioR ? I don't think it is a good idea to add a
counter in the Dataset class, which, moreover, should be carried over when
creating a new Dataset, otherwise it is useless. It'd be an overkill for this
IMO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
