cloud-fan commented on a change in pull request #19788: [SPARK-9853][Core]
Optimize shuffle fetch of contiguous partition IDs
URL: https://github.com/apache/spark/pull/19788#discussion_r242526217
##########
File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala
##########
@@ -295,8 +314,8 @@ private[spark] abstract class MapOutputTracker(conf:
SparkConf) extends Logging
* and the second item is a sequence of (shuffle block id, shuffle
block size) tuples
* describing the shuffle blocks that are stored at that block
manager.
*/
- def getMapSizesByExecutorId(shuffleId: Int, startPartition: Int,
endPartition: Int)
- : Iterator[(BlockManagerId, Seq[(BlockId, Long)])]
+ def getMapSizesByExecutorId(shuffleId: Int, startPartition: Int,
endPartition: Int,
+ serializerRelocatable: Boolean): Iterator[(BlockManagerId, Seq[(BlockId,
Long)])]
Review comment:
nit:
```
def fff(
param1: T,
param2: T): T
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
