cloud-fan commented on a change in pull request #23036: [SPARK-26065][SQL]
Change query hint from a `LogicalPlan` to a field
URL: https://github.com/apache/spark/pull/23036#discussion_r242574615
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala
##########
@@ -74,27 +84,31 @@ object CostBasedJoinReorder extends Rule[LogicalPlan] with
PredicateHelper {
* Extracts items of consecutive inner joins and join conditions.
* This method works for bushy trees and left/right deep trees.
*/
- private def extractInnerJoins(plan: LogicalPlan): (Seq[LogicalPlan],
Set[Expression]) = {
+ private def extractInnerJoins(
+ plan: LogicalPlan,
+ hintMap: mutable.HashMap[LogicalPlan, HintInfo]): (Seq[LogicalPlan],
Set[Expression]) = {
plan match {
- case Join(left, right, _: InnerLike, Some(cond)) =>
- val (leftPlans, leftConditions) = extractInnerJoins(left)
- val (rightPlans, rightConditions) = extractInnerJoins(right)
+ case Join(left, right, _: InnerLike, Some(cond), hint) =>
+ hint.leftHint.map(hintMap.put(left, _))
Review comment:
for purely side-effect function, use `foreach` instead of `map`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
