srowen commented on a change in pull request #22764: [SPARK-25765][ML] Add
training cost to BisectingKMeans summary
URL: https://github.com/apache/spark/pull/22764#discussion_r242575542
##########
File path:
mllib/src/main/scala/org/apache/spark/ml/clustering/BisectingKMeans.scala
##########
@@ -310,4 +317,6 @@ class BisectingKMeansSummary private[clustering] (
predictionCol: String,
featuresCol: String,
k: Int,
- numIter: Int) extends ClusteringSummary(predictions, predictionCol,
featuresCol, k, numIter)
+ numIter: Int,
+ @Since("3.0.0") val trainingCost: Double)
Review comment:
I don't think it's a big deal for 3.0, but we lose the constructor without
the new param. That's probably OK as the summary kind of needs this value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
