squito commented on a change in pull request #23340: [SPARK-23431][CORE] Expose
the new executor memory metrics at the stage level
URL: https://github.com/apache/spark/pull/23340#discussion_r242657999
##########
File path: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala
##########
@@ -790,6 +790,19 @@ private[spark] class AppStatusListener(
}
}
+ // update stage executor metrics
+ event.executorUpdates.foreach { updates =>
+ val activeStages = liveStages.values().asScala
+ .filter(_.status == v1.StageStatus.ACTIVE)
+ activeStages.foreach { stage =>
+ stage.peakExecutorMetrics.compareAndUpdatePeakValues(updates)
Review comment:
do you need a `maybeUpdate(stage, now)` after this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
