tgravescs commented on a change in pull request #23242: [SPARK-26285][CORE] accumulator metrics sources for LongAccumulator and Doub… URL: https://github.com/apache/spark/pull/23242#discussion_r242690626
########## File path: examples/src/main/scala/org/apache/spark/examples/AccumulatorMetricsTest.scala ########## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +// scalastyle:off println +package org.apache.spark.examples + +import org.apache.spark.metrics.source.{DoubleAccumulatorSource, LongAccumulatorSource} +import org.apache.spark.sql.SparkSession + +/** + * Usage: AccumulatorMetricsTest [partitions] [numElem] [blockSize] + */ +object AccumulatorMetricsTest { + def main(args: Array[String]) { + + val blockSize = if (args.length > 2) args(2) else "4096" + + val spark = SparkSession + .builder() + .config("spark.broadcast.blockSize", blockSize) + .getOrCreate() + + val sc = spark.sparkContext + + val acc = sc.longAccumulator("my-long-metric") + LongAccumulatorSource.register(sc, List(("my-long-metric" -> acc)).toMap) + + val acc2 = sc.doubleAccumulator("my-double-metric") + DoubleAccumulatorSource.register(sc, List(("my-double-metric" -> acc2)).toMap) + + val slices = if (args.length > 0) args(0).toInt else 2 + val num = if (args.length > 1) args(1).toInt else 1000000 + + val arr1 = (0 until num).toArray + + for (i <- 0 until 3) { + println(s"Iteration $i") + println("===========") + val startTime = System.nanoTime + val barr1 = sc.broadcast(arr1) + val observedSizes = sc.parallelize(1 to 10, slices).map(_ => { + acc.add(1) + acc2.add(1.1) + barr1.value.length Review comment: I think we could simplify the test by remove the broadcast stuff as that isn't really what we are testing, just leave the accumulator updates and do simple map. Print the accumulators at the end. Also perhaps we should put more information the register part and how someone running this might see those metrics output ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
