gatorsmile commented on issue #23343: [SPARK-26390][SQL] ColumnPruning rule should only do column pruning URL: https://github.com/apache/spark/pull/23343#issuecomment-448421546 In general, we normally do not encourage the code refactoring in optimizer rules. Any change could introduce a perf regression in query planning. For this PR, I think it is safe although it could slightly increase the number of runs in the big optimizer batch. LGTM. Please update the comment.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
