dongjoon-hyun commented on a change in pull request #23352:
[SPARK-26409][SQL][TESTS] SQLConf should be serializable in test sessions
URL: https://github.com/apache/spark/pull/23352#discussion_r243065400
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/internal/BaseSessionStateBuilder.scala
##########
@@ -309,13 +309,14 @@ private[sql] trait WithTestConf { self:
BaseSessionStateBuilder =>
def overrideConfs: Map[String, String]
override protected lazy val conf: SQLConf = {
+ val overrideConfigurations = overrideConfs
val conf = parentState.map(_.conf.clone()).getOrElse {
new SQLConf {
clear()
override def clear(): Unit = {
super.clear()
// Make sure we start with the default test configs even after clear
- overrideConfs.foreach { case (key, value) => setConfString(key,
value) }
+ overrideConfigurations.foreach { case (key, value) =>
setConfString(key, value) }
Review comment:
Technically, this is touching `src/main` instead of `src/test`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
