Github user brkyvz commented on the pull request:
https://github.com/apache/spark/pull/3468#issuecomment-64515054
Looks good to me! Just made one comment, no biggie though, it's fine as is
(but if you decide to change it, there are 4 exact copies of it).
One comment/question about using `Random`: What would be the problem if we
just pass a seed?
Since users wouldn't be able to use `XORShiftRandom`, which has better
performance than
`java.util.Random`, wouldn't passing the seed be enough to solve the
inconsistency issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
