devaraj-kavali commented on a change in pull request #19616:
[SPARK-22404][YARN] Provide an option to use unmanaged AM in yarn-client mode
URL: https://github.com/apache/spark/pull/19616#discussion_r243355288
##########
File path:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
##########
@@ -234,20 +218,26 @@ private[spark] class ApplicationMaster(args:
ApplicationMasterArguments) extends
resources.toMap
}
- def getAttemptId(): ApplicationAttemptId = {
- client.getAttemptId()
+ def getAttemptId(sparkConf: SparkConf): ApplicationAttemptId = {
+ client.getAttemptId(sparkConf)
}
final def run(): Int = {
doAsUser {
- runImpl()
+ runImpl(
+ if (isClusterMode) {
+ runDriver()
+ } else {
+ runExecutorLauncher()
+ }
+ )
}
exitCode
}
- private def runImpl(): Unit = {
+ private def runImpl(opBlock: => Unit): Unit = {
Review comment:
refactored this code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
