granthenke commented on a change in pull request #23354: [SPARK-26415][SQL]
Mark StreamSinkProvider and StreamSourceProvider as stable
URL: https://github.com/apache/spark/pull/23354#discussion_r243367829
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala
##########
@@ -111,13 +111,11 @@ trait SchemaRelationProvider {
}
/**
- * ::Experimental::
* Implemented by objects that can produce a streaming `Source` for a specific
format or system.
*
* @since 2.0.0
*/
-@Experimental
-@Unstable
+@Stable
trait StreamSourceProvider {
Review comment:
[Source](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/Source.scala)
and
[Sink](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/Sink.scala)
do not have any annotations on them. Does that imply they are stable? Sink and
Source are exposed/returned in the
[DataSource](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala#L252-L301)
class today as well.
I am happy to add a Stable annotation if that is your recommendation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
