gatorsmile commented on issue #23359: [SPARK-26416] [SQL] Refactor 
`ColumnPruning` from `Optimizer.scala` to `ColumnPruning.scala`
URL: https://github.com/apache/spark/pull/23359#issuecomment-449217014
 
 
   Discussed it with @dongjoon-hyun offline. There are various bug fixes in the 
code history. The change history is very valuable for us [especially for new 
contributors] to understand the code. Previously, we did the split, but it 
makes us much harder to find out the original PRs who introduced the changes. 
   
   For example, the following screenshot can clearly show all the PRs that 
changed this column pruning rule. The change history is very useful for 
reviewers and new learners. 
   
   ![screen shot 2018-12-20 at 6 10 41 
pm](https://user-images.githubusercontent.com/11567269/50320747-a6127d80-0482-11e9-87b8-eb9e06055b41.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to