beliefer edited a comment on issue #23355: [SPARK-26418][SHUFFLE] Only OpenBlocks without any ChunkFetch for one stream will cause memory leak in ExternalShuffleService URL: https://github.com/apache/spark/pull/23355#issuecomment-449220765 I check `OneForOneBlockFetcher` again, the method `start` use the same `TransportClient` to sent message `OpenBlocks` and following message `FetchChunkRequest`.There have no chance to call `TransportClientFactory.createClient`. So I think your change of code is OK, but still propose to add a parameter to control some timeout of `Channel`.When the time expired,call the following code ``` if (state.associatedChannel == channel) { streams.remove(entry.getKey()); // Release all remaining buffers. while (state.buffers.hasNext()) { state.buffers.next().release(); } } ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
