viirya commented on a change in pull request #23356: [SPARK-26422][R] Support
to disable Hive support in SparkR even for Hadoop versions unsupported by Hive
fork
URL: https://github.com/apache/spark/pull/23356#discussion_r243487314
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/api/r/SQLUtils.scala
##########
@@ -49,9 +49,10 @@ private[sql] object SQLUtils extends Logging {
sparkConfigMap: JMap[Object, Object],
enableHiveSupport: Boolean): SparkSession = {
val spark =
- if (SparkSession.hiveClassesArePresent && enableHiveSupport &&
+ if (enableHiveSupport &&
jsc.sc.conf.get(CATALOG_IMPLEMENTATION.key,
"hive").toLowerCase(Locale.ROOT) ==
- "hive") {
+ "hive" &&
+ SparkSession.hiveClassesArePresent) {
Review comment:
That is cool. But I think it is good to leave a comment here as there is no
test for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
