MaxGekk commented on a change in pull request #23358: [SPARK-26424][SQL] Use
java.time API in date/timestamp expressions
URL: https://github.com/apache/spark/pull/23358#discussion_r243553122
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala
##########
@@ -566,7 +566,7 @@ class DateFunctionsSuite extends QueryTest with
SharedSQLContext {
// february
val y1 = "2016-02-29"
- val y2 = "2017-02-29"
+ val y2 = "2017-02-32"
Review comment:
> Would it be better to set the mode to STRICT then?
I don't know how strict the `STRICT` mode. If I change it now in the PR,
most likely I have to made unrelated to this PR modifications. I would prefer
to do that in a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
