cloud-fan commented on a change in pull request #23358: [SPARK-26424][SQL] Use
java.time API in date/timestamp expressions
URL: https://github.com/apache/spark/pull/23358#discussion_r243719884
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala
##########
@@ -405,7 +405,7 @@ class DateFunctionsSuite extends QueryTest with
SharedSQLContext {
Row(Date.valueOf("2014-12-31"))))
checkAnswer(
df.select(to_date(col("s"), "yyyy-MM-dd")),
- Seq(Row(Date.valueOf("2015-07-22")), Row(Date.valueOf("2014-12-31")),
Row(null)))
+ Seq(Row(null), Row(Date.valueOf("2014-12-31")), Row(null)))
Review comment:
can we update the migration guide and mention that these datetime functions
also have behavior changes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
