dongjoon-hyun commented on a change in pull request #23369:
[SPARK-26429][SS]add jdbc sink for Structured Streaming.
URL: https://github.com/apache/spark/pull/23369#discussion_r243724548
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
##########
@@ -178,7 +178,7 @@ object JdbcUtils extends Logging {
}
}
- private def getJdbcType(dt: DataType, dialect: JdbcDialect): JdbcType = {
+ private[jdbc] def getJdbcType(dt: DataType, dialect: JdbcDialect): JdbcType
= {
Review comment:
This is good, but it's irrelevant to this PR. I'd like to recommend you not
to touch this file in this PR. That will help review processes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
