tgravescs commented on a change in pull request #23368:
[SPARK-26269][YARN][BRANCH-2.4] Yarnallocator should have same blacklist
behaviour with yarn to maxmize use of cluster resource
URL: https://github.com/apache/spark/pull/23368#discussion_r243738792
##########
File path:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala
##########
@@ -578,13 +578,29 @@ private[yarn] class YarnAllocator(
(true, memLimitExceededLogMessage(
completedContainer.getDiagnostics,
PMEM_EXCEEDED_PATTERN))
- case _ =>
- // all the failures which not covered above, like:
- // disk failure, kill by app master or resource manager, ...
- allocatorBlacklistTracker.handleResourceAllocationFailure(hostOpt)
- (true, "Container marked as failed: " + containerId + onHostStr +
- ". Exit status: " + completedContainer.getExitStatus +
- ". Diagnostics: " + completedContainer.getDiagnostics)
+ val pmemExceededPattern = raw"$MEM_REGEX of $MEM_REGEX physical
memory used".r
Review comment:
Looks like this is a merge conflict. this change was part of a different pr
https://github.com/apache/spark/commit/a00aaf649cb5a14648102b2980ce21393804f2c7
Can you remove this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
