HyukjinKwon commented on a change in pull request #23257: [SPARK-26310][SQL]
Verify applicability of JSON options
URL: https://github.com/apache/spark/pull/23257#discussion_r243783315
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
##########
@@ -128,6 +129,17 @@ private[sql] class JSONOptions(
allowBackslashEscapingAnyCharacter)
factory.configure(JsonParser.Feature.ALLOW_UNQUOTED_CONTROL_CHARS,
allowUnquotedControlChars)
}
+
+ def notApplicableOptions: Set[String]
+ def checkOptions(where: String): Unit = {
+ val wrongOptions = notApplicableOptions.filter(parameters.contains(_))
+ if (!wrongOptions.isEmpty && SQLConf.get.verifyDataSourceOptions) {
+ // scalastyle:off throwerror
Review comment:
I think we don't need this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
