Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/3484#issuecomment-64701438
I see. The only thing this changes is the `System.exit(x)` case, meaning
uncaught exceptions will still be properly treated as failures. This LGTM as a
hot fix, though I would like confirmation from @tgravescs if possible.
@vanzin @sryza If `finalStatus` defaults to `UNKNOWN` as before, then an
application that calls `System.exit(0)` will be retried and then eventually
fail. This is what you mean by "successful app", correct? If so then I think
it's better to change the default value to `SUCCESS` as this PR has done, so
that `System.exit(x)` will always be treated as failures (even if `x == 0`).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
