gatorsmile commented on a change in pull request #22284: [SPARK-25278][SQL]
Avoid duplicated Exec nodes when the same logical plan appears in the query
URL: https://github.com/apache/spark/pull/22284#discussion_r244027887
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/QueryPlanner.scala
##########
@@ -81,7 +81,7 @@ abstract class QueryPlanner[PhysicalPlan <:
TreeNode[PhysicalPlan]] {
childPlans.map { childPlan =>
// Replace the placeholder by the child plan
candidateWithPlaceholders.transformUp {
- case p if p == placeholder => childPlan
+ case p if p.eq(placeholder) => childPlan
Review comment:
Union is the last one we are not doing the dedup. I believe we need to fix
it. If we dedup Union children, we do not have a valid test case for this PR.
@mgaido91 Do you have any test case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
