maropu commented on a change in pull request #18576: [SPARK-21351][SQL] Update
nullability based on children's output
URL: https://github.com/apache/spark/pull/18576#discussion_r244075750
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -153,7 +153,9 @@ abstract class Optimizer(sessionCatalog: SessionCatalog)
RewritePredicateSubquery,
ColumnPruning,
CollapseProject,
- RemoveRedundantProject)
+ RemoveRedundantProject) :+
+ Batch("UpdateAttributeReferences", Once,
+ UpdateNullabilityInAttributeReferences)
Review comment:
Yea, I see... But, I have no idea about the way to resolve the two issue
(the correctness issue and the optimization issue) simultaneously in a single
place. I think there is one greedy & temporary solution that merges the current
two rule into one, and then put it in the two places: the analyzer and the
optimizer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
