seancxmao commented on a change in pull request #23258:
[SPARK-23375][SQL][FOLLOWUP][TEST] Test Sort metrics while Sort is missing
URL: https://github.com/apache/spark/pull/23258#discussion_r244087694
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsTestUtils.scala
##########
@@ -198,6 +199,52 @@ trait SQLMetricsTestUtils extends SQLTestUtils {
}
}
}
+
+ private def metricStats(metricStr: String): Seq[String] = {
+ val sum = metricStr.substring(0,
metricStr.indexOf("(")).stripPrefix("\n").stripSuffix(" ")
+ val minMedMax = metricStr.substring(metricStr.indexOf("(") + 1,
metricStr.indexOf(")"))
+ .split(", ").toSeq
+ (sum +: minMedMax)
+ }
+
+ private def stringToBytes(str: String): (Float, String) = {
+ val matcher =
+ Pattern.compile("([0-9]+(\\.[0-9]+)?)
(EiB|PiB|TiB|GiB|MiB|KiB|B)").matcher(str)
+ if (matcher.matches()) {
+ (matcher.group(1).toFloat, matcher.group(3))
+ } else {
+ throw new NumberFormatException("Failed to parse byte string: " + str)
+ }
+ }
+
+ private def stringToDuration(str: String): (Float, String) = {
+ val matcher = Pattern.compile("([0-9]+(\\.[0-9]+)?)
(ms|s|m|h)").matcher(str)
Review comment:
Fixed with a new commit. I also extracted
`Pattern.compile("([0-9]+(\\.[0-9]+)?) (ms|s|m|h)")`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
